Skip to content

fix(ext/node): emit resize event on SIGWINCH #27363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(ext/node): emit resize event on SIGWINCH #27363

wants to merge 5 commits into from
+57 −23

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Dec 14, 2024 •
edited
Loading 

process.stdout.on("resize", () => {
  console.log(`resize ${process.stdout.columns}x${process.stdout.rows}`);
});

Fixes #26671

@littledivy littledivy mentioned this pull request Mar 23, 2025
Open
dsherret
dsherret approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once main is merged in.

dsherret
dsherret reviewed May 20, 2025
View reviewed changes
ext/node/polyfills/process.ts
if (stdout.isTTY) {
Deno.addSignalListener("SIGWINCH", () => {
stdout.emit("resize");
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this doesn't work on Windows? Will this error?

dsherret
dsherret requested changes May 20, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. I think this will throw an exception on Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resize event on stdout not invoked in TTY on macOS
2 participants
@littledivy @dsherret